Add `topological_sort()` to `datanames(teal_data())` and also extend `datanames()` with parent dataset when it is provided in `join_keys` #319

m7pr · 2024-07-31T12:30:02Z

Part of insightsengineering/teal#1253

This PR introduced below changes

teal_data() constructor does not put names(join_keys) in default datanames(teal_data()) to maintain consistency with other features, where we do not allow datanames() to contain names of objects that do not exist in @env
datanames() now sorts names topologically based on provided join_keys()
each time datanames() and join_keys() is overwritten the sort is applied to teal_data()@datanames
provided few more tests
adjusted 2 tests that assumed extraction of datanames() from join_keys is fine - but it's not right now as we do not allow datanames() to contain names of objects that do not exists in @env

Will provide testing in this PR in teal as well https://github.com/insightsengineering/teal/pull/1280/files

Merge branch 'main' of https://github.com/insightsengineering/teal.data # Conflicts: # tests/testthat/test-get_code.R

Signed-off-by: Marcin <[email protected]>

Update R/teal_data-datanames.R Signed-off-by: Marcin <[email protected]> add two tests for topological_sort

…om/insightsengineering/teal.data into topological_sort@669_insertUI@main

Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>

…om/insightsengineering/teal.data into topological_sort@669_insertUI@main

…in_keys as they might refer to datanames that do not exist in env

github-actions · 2024-07-31T12:30:17Z

✅ All contributors have signed the CLA
_{Posted by the CLA Assistant Lite bot.}

m7pr · 2024-07-31T12:31:03Z

I have read the CLA Document and I hereby sign the CLA

m7pr · 2024-07-31T12:31:07Z

recheck

gogonzo · 2024-07-31T12:32:32Z

I have read the CLA Document and I hereby sign the CLA

github-actions · 2024-07-31T12:39:14Z

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  --------------------
R/cdisc_data.R                       1       0  100.00%
R/deprecated.R                      57      57  0.00%    19-344
R/dummy_function.R                   2       2  0.00%    14-15
R/formatters_var_labels.R           61       0  100.00%
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   35-38
R/join_keys.R                       22       0  100.00%
R/teal_data-class.R                 26       1  96.15%   69
R/teal_data-datanames.R             20       0  100.00%
R/teal_data-get_code.R              14       0  100.00%
R/teal_data-show.R                   4       4  0.00%    14-19
R/teal_data.R                       30      16  46.67%   33, 36-42, 52-58, 61
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      187       1  99.47%   282
R/verify.R                          42      11  73.81%   65, 95-99, 102-106
TOTAL                              865      95  89.02%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  --------
R/join_keys.R                 +1       0  +100.00%
R/teal_data-class.R           +1       0  +0.15%
R/teal_data-datanames.R      +10       0  +100.00%
TOTAL                        +12       0  +0.15%

Results for commit: 56fc828

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

github-actions · 2024-07-31T12:39:22Z

Unit Tests Summary

1 files 14 suites 2s ⏱️
203 tests 201 ✅ 2 💤 0 ❌
276 runs 274 ✅ 2 💤 0 ❌

Results for commit 56fc828.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-31T12:39:39Z

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
datanames	👶		$+0.00$	datanames_are_set_in_topological_order_in_constructor_if_join_keys_are_specified
datanames	👶		$+0.00$	datanames_do_not_return_parent_if_in_constructor_it_was_provided_in_join_keys_but_do_not_exists_in_env
datanames	👶		$+0.01$	datanames_do_not_return_parent_if_join_keys_were_provided_and_parent_did_not_exists_in_env
datanames	👶		$+0.01$	datanames_return_parent_if_in_constructor_it_was_provided_in_join_keys_and_exists_in_env
datanames	👶		$+0.01$	datanames_return_parent_if_join_keys_were_provided_and_parent_exists_in_env
datanames	👶		$+0.01$	datanames_return_topological_order_of_datasets_after_datanames_are_called_after_join_keys
datanames	👶		$+0.01$	datanames_return_topological_order_of_datasets_once_join_keys_are_specified
teal_data	💀	$0.00$	$-0.00$	teal_data_initializes_teal_data_object_with_datanames_taken_from_join_keys_and_passed_objects
teal_data	💀	$0.00$	$-0.00$	teal_data_initializes_teal_data_object_with_datanames_taken_from_passed_join_keys
teal_data	👶		$+0.00$	teal_data_initializes_teal_data_object_with_datanames_taken_only_from_passed_objects_and_not_join_keys
teal_data	👶		$+0.00$	teal_data_initializes_teal_data_object_without_datanames_taken_from_join_keys_if_objects_did_not_exist_in_env

Results for commit 7b68a03

♻️ This comment has been updated with latest results.

gogonzo · 2024-07-31T13:16:46Z

@m7pr please add a NEWS entry and fix GHA checks

…ering/teal.data into 669_insertUI@main

m7pr · 2024-08-01T10:02:22Z

Hey @gogonzo NEWS enhanced! that was a long one.
Fixed lintr and spelling checks as well!

gogonzo · 2024-08-01T10:16:11Z

👍

m7pr and others added 26 commits January 18, 2024 11:54

test for ; case

c8a448c

merge

a942d60

Merge branch 'main' of https://github.com/insightsengineering/teal.data # Conflicts: # tests/testthat/test-get_code.R

Merge branch 'main' of https://github.com/insightsengineering/teal.data

d276477

Merge branch 'main' of https://github.com/insightsengineering/teal.data

d2727d4

Merge branch 'main' of https://github.com/insightsengineering/teal.data

3fa1a8d

Merge branch 'main' of https://github.com/insightsengineering/teal.data

b4d1d9f

Merge branch 'main' of https://github.com/insightsengineering/teal.data

fc2e59e

Merge branch 'main' of https://github.com/insightsengineering/teal.data

484915e

Merge branch 'main' of https://github.com/insightsengineering/teal.data

a53e3a1

Merge branch 'main' of https://github.com/insightsengineering/teal.data

3c98a37

Merge branch 'main' of https://github.com/insightsengineering/teal.data

f195d1c

Merge branch 'main' of https://github.com/insightsengineering/teal.data

c0d8065

Merge branch 'main' of https://github.com/insightsengineering/teal.data

4eeca16

WIP - topological sort for datanames

5cdb5f7

Update R/teal_data-datanames.R

621cfb5

Signed-off-by: Marcin <[email protected]>

add two tests for topological_sort

96228a0

WIP - topological sort for datanames

784965b

Update R/teal_data-datanames.R Signed-off-by: Marcin <[email protected]> add two tests for topological_sort

Merge branch 'topological_sort@669_insertUI@main' of https://github.c…

2cbff27

…om/insightsengineering/teal.data into topological_sort@669_insertUI@main

Update R/teal_data-datanames.R

3050093

Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>

[skip style] [skip vbump] Restyle files

c8ebd82

datanames() test for join_keys set during teal_data creation

8a84286

Merge branch 'topological_sort@669_insertUI@main' of https://github.c…

e58c298

…om/insightsengineering/teal.data into topological_sort@669_insertUI@main

[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update

ee389a5

set safely

f6be311

typo

a3ece0e

add more tests for datanames() and do not extract datanames() from jo…

b395c29

…in_keys as they might refer to datanames that do not exist in env

m7pr added the core label Jul 31, 2024

[skip style] [skip vbump] Restyle files

93c2117

m7pr mentioned this pull request Jul 31, 2024

use topological_sort on datanames() insightsengineering/teal#1280

Merged

[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update

4d46524

m7pr and others added 6 commits August 1, 2024 11:04

enhance news

81529f3

superlintr fixes

0ecb617

[skip style] [skip vbump] Restyle files

480df2c

quote Kahn

c61416e

Merge branch '669_insertUI@main' of https://github.com/insightsengine…

ff924df

…ering/teal.data into 669_insertUI@main

extend Wordlist

b9dd005

gogonzo approved these changes Aug 1, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into 669_insertUI@main

56fc828

m7pr merged commit d240c22 into main Aug 12, 2024
28 checks passed

m7pr deleted the 669_insertUI@main branch August 12, 2024 11:34

github-actions bot locked and limited conversation to collaborators Aug 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `topological_sort()` to `datanames(teal_data())` and also extend `datanames()` with parent dataset when it is provided in `join_keys` #319

Add `topological_sort()` to `datanames(teal_data())` and also extend `datanames()` with parent dataset when it is provided in `join_keys` #319

m7pr commented Jul 31, 2024

github-actions bot commented Jul 31, 2024 •

edited

Loading

m7pr commented Jul 31, 2024

m7pr commented Jul 31, 2024

gogonzo commented Jul 31, 2024

github-actions bot commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024 •

edited

Loading

gogonzo commented Jul 31, 2024

m7pr commented Aug 1, 2024

gogonzo commented Aug 1, 2024

Add topological_sort() to datanames(teal_data()) and also extend datanames() with parent dataset when it is provided in join_keys #319

Add topological_sort() to datanames(teal_data()) and also extend datanames() with parent dataset when it is provided in join_keys #319

Conversation

m7pr commented Jul 31, 2024

github-actions bot commented Jul 31, 2024 • edited Loading

m7pr commented Jul 31, 2024

m7pr commented Jul 31, 2024

gogonzo commented Jul 31, 2024

github-actions bot commented Jul 31, 2024 • edited Loading

Code Coverage Summary

Diff against main

github-actions bot commented Jul 31, 2024 • edited Loading

Unit Tests Summary

github-actions bot commented Jul 31, 2024 • edited Loading

Unit Test Performance Difference

gogonzo commented Jul 31, 2024

m7pr commented Aug 1, 2024

gogonzo commented Aug 1, 2024

Add `topological_sort()` to `datanames(teal_data())` and also extend `datanames()` with parent dataset when it is provided in `join_keys` #319

Add `topological_sort()` to `datanames(teal_data())` and also extend `datanames()` with parent dataset when it is provided in `join_keys` #319

github-actions bot commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024 •

edited

Loading